Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing on touch devices loses selection #5706

Closed
sirkosi opened this issue Aug 10, 2020 · 8 comments
Closed

Resizing on touch devices loses selection #5706

sirkosi opened this issue Aug 10, 2020 · 8 comments

Comments

@sirkosi
Copy link

sirkosi commented Aug 10, 2020

Reduced Test Case

https://codepen.io/sirsir1/pen/GRZJaZG

Bug Description

When providing simple HTML-Markup to eventContent, the dragged (to be resized) Element loses the resize markers before the resize can be done.
This only occurs when you touch within the text area, if you tap in the part of the Element without text it works as expected (resize markers stay and can be used).

Also, when providing plain text content to eventContent it seems to work fine.

Screenshots

Screenshot 2020-08-10 at 15 42 30

@sirkosi sirkosi changed the title DnD leaves Element unselected with Multitouch Resizing on touch devices loses selection Aug 10, 2020
@arshaw
Copy link
Member

arshaw commented Aug 11, 2020

Could this issue be related to this other issue? #5691

@arshaw arshaw added this to the next-release milestone Aug 11, 2020
@sirkosi
Copy link
Author

sirkosi commented Aug 11, 2020

@arshaw from what I understand the element in #5691 keeps freezing, which is definitely not the case with this issue here. The element stays fully functional, only the resize markers disappear.

@sirkosi
Copy link
Author

sirkosi commented Aug 11, 2020

A functional workaround at the moment for this issue is to reconstruct any html-markup via createElement functions.

Instead of:

eventContent: { html: '<span>F2<br><i>18:00</i></span>' }

Use this:

eventContent: function(arg, createElement) {
  return createElement('span', {}, createElement('span', {}, 'F2'), createElement("br"), createElement('i',{}, "18:00"));
}

@arshaw
Copy link
Member

arshaw commented Aug 11, 2020

@Sir-ko , could you clarify what you mean by "This only occurs when you touch within the text area"? What text area? Shouldn't you be interacting with the circle resizers? If you could post a video or animated GIF with you interacting with it, that would be really helpful.

Also, what type of browser/device are you using?

@arshaw arshaw removed this from the next-release milestone Aug 11, 2020
@sirkosi
Copy link
Author

sirkosi commented Aug 11, 2020

@arshaw Of course, I will try my best to explain my findings.

Regarding "This only occurs when you touch within the text area" I was refering to the text and blank space inside the element, see the following screenshot (I hope the image is not too confusing).

image

In the following video I'm trying 2 times to select the element by clicking on the text. The third time I clicked into the upper right area of the element without text. Only on the last attempt the resize markers stay in it's place. The first two times it is not possible to select the element in order to resize it.

Screenvideo: https://www.dropbox.com/s/5cq8rr23vb0efls/broken_element_selection.mov?dl=0

Please let me know if this was clear or if you need more information.

To reproduce this, I am using Safari on iPhone (iOS 13.5.1) and Chrome v84.0 on Android.

@sirkosi
Copy link
Author

sirkosi commented Aug 12, 2020

@arshaw I could reproduce it easily on MacOS (10.15.5) with Chrome (84.0.4147.105) Mobile view.

https://www.dropbox.com/s/32vy7bv6v400r10/broken_element_selection_2.mov?dl=0

@arshaw
Copy link
Member

arshaw commented Aug 12, 2020

@Sir-ko thank you so much. I finally understand and can reproduce. I'll work on a fix for the next minor release

@arshaw arshaw added this to the next-release milestone Aug 12, 2020
@arshaw arshaw closed this as completed in 48bad7a Aug 12, 2020
@arshaw
Copy link
Member

arshaw commented Aug 12, 2020

this has been fixed in 5.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants