Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in 8.2.0 #162

Closed
giri3sg opened this issue May 5, 2020 · 0 comments
Closed

Breaking changes in 8.2.0 #162

giri3sg opened this issue May 5, 2020 · 0 comments

Comments

@giri3sg
Copy link

giri3sg commented May 5, 2020

I'm submitting a ... (check one with "x")

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  <!-- Please check the repository for a similar issue or PR before submitting -->
[ ] Support request => <!-- Please check the repository for a similar issue or PR before submitting -->

v8.1.0...v8.2.0

How come this package have breaking changes in minor version?
Why is the upgrade to angular 9 is done in v8.2.0?
this will break lot of projects that depend on this module.
Please provide a fix in 8.2.1 or something.

my project uses angular 8,
and has a dependency

"@ngx-config/core": "^8.0.1"

8.1.0 has

{
"peerDependencies": {
  "@angular/common": ">=8.0.0 <9.0.0",
  "@angular/core": ">=8.0.0 <9.0.0",
  "@angular/platform-browser-dynamic": ">=8.0.0 <9.0.0"
  }
}

8.2.0 has

{
  "peerDependencies": {
    "@angular/common": ">=9.0.0 <10.0.0",
    "@angular/core": ">=9.0.0 <10.0.0",
    "@angular/platform-browser-dynamic": ">=9.0.0 <10.0.0"
  }
}

P.S. I am happy that you are supporting angular 9, and i'm grateful, but please follow semver, otherwise you gonna break lot of projects.

@fulls1z3 fulls1z3 closed this as completed Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants