Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMR app.scss #35

Closed
theomathieubhvr opened this issue Jul 12, 2017 · 4 comments
Closed

HMR app.scss #35

theomathieubhvr opened this issue Jul 12, 2017 · 4 comments

Comments

@theomathieubhvr
Copy link
Contributor

The sass files in assets/sass are not live reloaded when a changes occured.

I'll try to fix soon this when I have time available.
My PR might be in angular-webpack-config repo.

@fulls1z3
Copy link
Owner

@theomathieubhvr thank you very much for finding out this, seems like this feature need some enhancements.

Meanwhile I'll invite you as a contibutor to this project as well as angular-webpack-config project. And I will do the same if you're interested in others (almost all dependencies with ngx- prefix).

@fulls1z3 fulls1z3 changed the title [Enhancement] HMR app.scss [enhancement] HMR app.scss Jul 12, 2017
@theomathieubhvr theomathieubhvr changed the title [enhancement] HMR app.scss HMR app.scss Jul 12, 2017
@theomathieubhvr theomathieubhvr changed the title HMR app.scss [enhancement] HMR app.scss Jul 12, 2017
@theomathieubhvr
Copy link
Contributor Author

Ok, I'll do it ASAP. I've succeeded in doing this when you didn't use angular-webpack-config. I should be able to make it working with angular-webpack-config.

@fulls1z3
Copy link
Owner

I know that angular-webpack-config seems to make things a little more complicated, but I'm depending on the same config on 10+ projects. Every time this config needs an update I had to make the changes on all those projects (which leads to mistakes, issues, etc.).

With angular-webpack-config changes are more or less centralized, increasing the version number works like a charm in most cases 😄

@theomathieubhvr
Copy link
Contributor Author

@fulls1z3 fulls1z3 changed the title [enhancement] HMR app.scss [enhancement] HMR app.scss Aug 2, 2017
@fulls1z3 fulls1z3 closed this as completed Aug 2, 2017
@fulls1z3 fulls1z3 changed the title [enhancement] HMR app.scss HMR app.scss Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants