-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
styling is overwritten from the javascript #9
Comments
Ah, yes... this is inside the component itself here: https://github.com/fullstackreact/google-maps-react/blob/master/src/index.js#L177 You can override this default or perhaps it makes sense to create an option to apply these styles conditionally. What do you think? |
I think a flag that is passable to the option is a good idea, if it is passed false it will apply no styles from the source component. Thank you for your response. Great work with this. |
Sure. Wanna try a PR, @Szarko ? |
bump ^^ |
Did anyone fix this? I can't for the life of me set the position to 'relative'. Would fix all my problems. Tried changing the css, internal css, and it keeps forcing 'absolute'. |
@TheMaverickProgrammer did you manage to fix it? I struggled with this for a while but made it work. I took out the |
No I wrote my own |
I’ll remove the default styling in the js and leave it up to the user to define styles.
Cheers!
Ari Lernercurl -IL http://ari.io
On Wed, Sep 27, 2017 at 1:11 PM -0700, "Maverick Peppers" <notifications@github.com> wrote:
No I wrote my own
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Anyone know how to remove the width and height 100% on the parent div ? |
The best way to fix this issue is this.
In the css file define css rules to the miniMap class
|
hey @TheMaverickProgrammer can you publish the source code for the map component? |
I am not sure how you managed to apply the styles in the yelp clone demo.
The JS keeps applying 100% to width and height and position: absolute every time a Map is rendered.
The text was updated successfully, but these errors were encountered: