Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database ref.on does not work on Android #31

Closed
alexkendall opened this issue Sep 15, 2016 · 16 comments
Closed

Database ref.on does not work on Android #31

alexkendall opened this issue Sep 15, 2016 · 16 comments
Assignees
Labels

Comments

@alexkendall
Copy link

I have the same exact code on Android and iOS for observing value changes on my database. It works on iOS as expected but does not work on Android. I have placed my code below as a reference:

.ref("shifts")
    .on('value', snapshot => {
    console.log(snapshot)
 })
@auser
Copy link
Contributor

auser commented Sep 15, 2016

Are you working on master or the npm module?

@alexkendall
Copy link
Author

I believe so... I installed it using "npm install react-native-firestack --save".

@auser
Copy link
Contributor

auser commented Sep 15, 2016

Hmm... that's the latest... I'll check over here too

@alexkendall
Copy link
Author

Thanks, really appreciate it.

@auser
Copy link
Contributor

auser commented Sep 15, 2016

I'm seeing it here too... currently debugging...

@auser
Copy link
Contributor

auser commented Sep 15, 2016

Okay, tracked it down. I should have a fix here shortly

@alexkendall
Copy link
Author

Cool sounds great.

@auser
Copy link
Contributor

auser commented Sep 15, 2016

@alexkendall got it.

Want to test it on your end?

@alexkendall
Copy link
Author

Yup. Will be glad to.

@auser
Copy link
Contributor

auser commented Sep 15, 2016

Have one more fix coming...

@auser
Copy link
Contributor

auser commented Sep 15, 2016

Okay, good news and bad news!

Good: It's fixed
Bad: I pushed it to the feature/messaging branch. Can you pull and try it from that branch?

@auser auser added the bug label Sep 16, 2016
@auser auser self-assigned this Sep 16, 2016
@alexkendall
Copy link
Author

I pulled from the messaging branch and can confirm that the issue is fixed. Thanks a ton!

@auser
Copy link
Contributor

auser commented Sep 16, 2016

@alexkendall awesome! Feel free to report any bugs whenever you encounter one. It definitely helps.

I hope to get the push notifications/messaging in/complete this weekend!

@auser auser closed this as completed Sep 16, 2016
@blumanski
Copy link
Contributor

@auser
Was that ever merged into the master branch?
I work from the master branch and the problem is till there on android.

@auser
Copy link
Contributor

auser commented Oct 11, 2016

Hmm... yes, I think it is on the master branch. Have a git repo I can check out?

@blumanski
Copy link
Contributor

Ah, yeah, I wrote it wrong, I used a promise instead of a callback...
All good, Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants