Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-open-browser=true doesn't work properly on faulty open handlers #230

Closed
nedsociety opened this issue Mar 18, 2023 · 0 comments · Fixed by #232
Closed

-open-browser=true doesn't work properly on faulty open handlers #230

nedsociety opened this issue Mar 18, 2023 · 0 comments · Fixed by #232

Comments

@nedsociety
Copy link

nedsociety commented Mar 18, 2023

  • Ubuntu jammy, running on WSLg Windows 22H2 (22621.1413)
  • xdg-open 1.1.3
  • google-chrome 111.0.5563.64, installed via apt
  • grpcui 3cc36d3, using go install

Running grpcui doesn't work and the browser keeps trying connection... until you close the browser! If the browser is closed and another is opened then it starts working.

The default open handler is faulty for google-chrome since it blocks until the browser exits. As consequence browser.OpenURL() is a blocking call preventing grpcui process to do its job. A workaround might be to make the call asynchronously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant