Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Git not configured" fatal error #3

Closed
Keyaku opened this issue Nov 15, 2016 · 7 comments
Closed

"Git not configured" fatal error #3

Keyaku opened this issue Nov 15, 2016 · 7 comments

Comments

@Keyaku
Copy link

Keyaku commented Nov 15, 2016

So, I manage many repos on my machine, so of course I have Git set up with my e-mail and username.

And yet, upon activation, I get a "Git not configured" error from your plugin.

UPDATE:
It must failing to fetch my data from my system.

@iamfunsho
Copy link
Collaborator

Please what OS

@Keyaku
Copy link
Author

Keyaku commented Nov 16, 2016

Sorry about that.

Running macOs Sierra (10.12.1) and Godot from master.

@iamfunsho
Copy link
Collaborator

The problem is that i didn't test it on OSX cause i don't own a Mac or Hack but can you please run this command in your terminal and tell me what it prints

whereis -b git

@Keyaku
Copy link
Author

Keyaku commented Nov 17, 2016

I found the problem.

Just swap the line (at command_manager.gd::76):
return self.run_command(["-b", "git"], "whereis")[0].strip_edges();
with
return self.run_command(["git"], "whereis")[0].strip_edges();

OS X does not support the -b flag in whereis.

Also, reminder: don't forget to update the plugin version number in plugin.cfg::7! You forgot the last time

@iamfunsho
Copy link
Collaborator

iamfunsho commented Nov 17, 2016

What a coincidence :D, I have already change from using whereis to which binary (for searching for git) on both linux and mac (I have already pushed the changes). Please test it to see if there are any issues.

@iamfunsho
Copy link
Collaborator

iamfunsho commented Nov 17, 2016

You are free to close this issue if everything works fine. Also since it's still in alpha (and there are still some stuffs i will love to add) , i don't really what to change the version, i only did that because of asset-library. Maybe when i push a stable version (hopefully this weekend), i will update it.

@Keyaku
Copy link
Author

Keyaku commented Nov 17, 2016

I would, but this wasn't yet updated on the AssetLib D:

No matter, I downloaded the changed files and applied them. Works great! Thanks.

@Keyaku Keyaku closed this as completed Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants