Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equality is broken for non decimal types #10

Open
jjttjj opened this issue Sep 16, 2020 · 1 comment · May be fixed by #11
Open

Equality is broken for non decimal types #10

jjttjj opened this issue Sep 16, 2020 · 1 comment · May be fixed by #11

Comments

@jjttjj
Copy link

jjttjj commented Sep 16, 2020

(= (dc/decimal 123) :x)
results in

#object[Error Error: [DecimalError] Invalid argument: :x]

Due to the IEquiv implementation here:

decimal/src/decimal/core.cljs

Line 752 in c0bee2e

(.eq v other)))

It should check that the thing being compared is a number or decimal type.

I will send a PR soon.
@jjttjj jjttjj linked a pull request Sep 7, 2021 that will close this issue
Open
@hipitihop
Copy link

We have seen the same with not=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix equality implementation for comparisons against non-decimals jjttjj/decimal
2 participants
@jjttjj @hipitihop