Port unit tests from fs3 topic #1478
Conversation
…/fs3 after they were modified by IntelliJ. Enabled 3 tests that were pending that consistently succeed on the series/1.0 branch.
…ated tests generate warnings which lead to test failures
|
Oh wow, that's a lot of work, thanks a lot! |
|
Yep, those are mostly in StreamSpec now
…Sent from my iPhone
On May 24, 2019, at 3:04 PM, Fabio Labella ***@***.***> wrote:
Oh wow, that's a lot of work, thanks a lot!
Quick question, I've seen that some things were deleted (like GroupWithinSpec or ResourceCompilationSpec), where they moved in other files? (before I go review the whole thing)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
quick heads up: there are several test failures , which at quick glance looks like timeouts (so possibly things hanging) |
|
I'll take a look at the test failures |
|
|
||
| abstract class AsyncFs2Spec extends AsyncFreeSpec with Fs2SpecLike with AsyncTimeLimitedTests { | ||
| implicit val timeout: FiniteDuration = 10.seconds |
There was a problem hiding this comment.
Bump this back to 60 seconds -- this is likely the cause of most/all of the timeouts on Travis
There was a problem hiding this comment.
btw, maybe this requires a different PR, but I think we should investigate using TestContext more instead of actual time
…arked as pending back to pending
| @@ -2125,6 +2125,7 @@ class StreamSpec extends Fs2Spec { | |||
| } | |||
|
|
|||
| "resources acquired in outer stream are released after inner streams complete" in { | |||
| pending | |||
There was a problem hiding this comment.
Odd, these are passing on series/1.x AFAIK
There was a problem hiding this comment.
I'm commenting them out for now, but may re-add them after I address the fact that flickersOnTravis is not behaving as expected (does not exclude tests on Travis like it should)
…y to be reflected in the test javaOptions. This fixes the issue where flickersOnTravis in Fs2Spec was always a no-op. Marked the test 'inner stream finalizer always runs before switching' as pending because it was observed hanging both in the Travis environment and locally. Re-enabled 3 tests that should run in the series/1.0 branch
|
All tests are passing after my latest round of changes. In summary: Fixed the issue with flickersOnTravis not being applied (related to: https://stackoverflow.com/questions/27486540/jvm-options-not-passed-on-to-forked-process) and marked one additional test as pending that was failing both locally and on Travis. |
|
Awesome work! |
Existing series/1.0 test classes were deleted and replaced with those from the topic/fs3 branch.
A few minor modifications were made: