Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API access control. #254

Open
farhoud opened this issue Jul 18, 2022 · 3 comments
Open

API access control. #254

farhoud opened this issue Jul 18, 2022 · 3 comments

Comments

@farhoud
Copy link
Contributor

farhoud commented Jul 18, 2022

File protocol does not have access control.
So if you connect it to public network any one can use it to upload and download from them.

@gitaaron
Copy link
Contributor

So currently if I run the cluster with docker-compose it is not connected to the public network?

However, if we wanted to make it available to signalling server then we would have to make it available to the public network?

Is it the bootstrap server list that determines that?

@ehsan6sha
Copy link
Member

@farhoud can you elaborate a bit? When we say File Protocol does not have access control?
I mean right now, we encrypt the file and upload it, and then when we share we go through the security layer that Jamshid designed. what part is still not encrypted?

@farhoud
Copy link
Contributor Author

farhoud commented Jul 18, 2022

@gitaaron currently its disabled in code for bootstraps but wrtc still connect box to network which should be removed.

@farhoud can you elaborate a bit? When we say File Protocol does not have access control?
I mean right now, we encrypt the file and upload it, and then when we share we go through the security layer that Jamshid designed. what part is still not encrypted?

@ehsan6sha you can not control who is connecting to your box, data is encrypted but anybody in the network can use any box as their storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants