Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformer throwing Errors kills the TypeScript language server #11

Closed
sam-goodwin opened this issue Feb 28, 2022 · 0 comments · Fixed by #46
Closed

Transformer throwing Errors kills the TypeScript language server #11

sam-goodwin opened this issue Feb 28, 2022 · 0 comments · Fixed by #46
Assignees

Comments

@sam-goodwin
Copy link
Collaborator

Currently, when the TypeScript transformer encounters a node it does not understand, we just throw an Error and display the syntax (text) that could not be processed. This is not too big of a deal when running tsc, but it kills the language server when editing in VS code.

Instead, the transformer should not throw and instead output a NullLiteral or ErrorNode to the AST.

For errors, we will rely on a language service plugin (see: #10) to add domain-specific diagnostics instead of throwing an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants