-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the logging configuration for ExpressStepFunction does not trigger a redeploy #441
Comments
I believe the root cause is fixed in #425, though it may be a while before that PR is merged, should hoist it to it's own PR. :( |
Root cause: no props are being passed at all :/ |
Ah array lookup, a TypeScript types fan's worst enemy. |
And me being lazy and not writing a test for props... |
And using |
OK compiler just pretend it looks like a duck. Really wish they would have made that a proper coercion operator, adding a check and returning the type or null like in most sane typed languages. |
Steps to reproduce:
ExpressStepFunction
with no logging configurationExpected outcome:
The Step Function should be updated with the new logging config.
Actual outcome:
The logging configuration remains unmodified.
The text was updated successfully, but these errors were encountered: