Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the logging configuration for ExpressStepFunction does not trigger a redeploy #441

Closed
tvanhens opened this issue Aug 25, 2022 · 6 comments · Fixed by #444
Closed
Assignees

Comments

@tvanhens
Copy link
Contributor

Steps to reproduce:

  1. Deploy an ExpressStepFunction with no logging configuration
  2. Add a logging configuration.
  3. Re-deploy

Expected outcome:

The Step Function should be updated with the new logging config.

Actual outcome:

The logging configuration remains unmodified.

@thantos
Copy link
Collaborator

thantos commented Aug 25, 2022

I believe the root cause is fixed in #425, though it may be a while before that PR is merged, should hoist it to it's own PR.

here: https://github.com/functionless/functionless/pull/425/files#diff-961ed18b565d502c0f3e3673413b522c59ba0121e9bec07aca2807cf73309addL1584-R1586

:(

@thantos thantos self-assigned this Aug 25, 2022
@thantos
Copy link
Collaborator

thantos commented Aug 25, 2022

Root cause: no props are being passed at all :/

@tvanhens
Copy link
Contributor Author

Ah array lookup, a TypeScript types fan's worst enemy.

@thantos
Copy link
Collaborator

thantos commented Aug 25, 2022

And me being lazy and not writing a test for props...

@thantos
Copy link
Collaborator

thantos commented Aug 25, 2022

Ah array lookup, a TypeScript types fan's worst enemy.

And using as in typescript.

@tvanhens
Copy link
Contributor Author

OK compiler just pretend it looks like a duck.

Really wish they would have made that a proper coercion operator, adding a check and returning the type or null like in most sane typed languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants