feat: allow for injected functions #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
sam-goodwin
reviewed
Jun 24, 2022
Comment on lines
+559
to
+565
| const funcEntry = context.cache.get(func); | ||
| if (!funcEntry) { | ||
| throw new Error( | ||
| "Entry for this this function was not created by caller" | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why does moving this here change things?
There was a problem hiding this comment.
They process all functions beforehand and cache the results. We are injecting a function that was not processed.
The cached entry is only used when the function is named, so I moved it to fail at the last moment. It may still fail later, but this unblocks us.
sam-goodwin
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for the
serializefunction to accept Function expr or Arrow Expr and return values.previously
serializewould throw an error when a function was returned.