#113: Targeting ES5 environments with module file while maintaining import/export statements for tree shaking

[kayneb]

This PR updates the Typescript config so that the outputted JS is ES5 compatible, yet maintains import/export statements, as per is intended by the module attribute (https://github.com/rollup/rollup/wiki/pkg.module).

[kayneb]

Just noticed the tests aren't working anymore. Will look into it when I get the chance.

[alexandru]

@kayneb thanks for the PR, but I don't agree with the premise.

The "module" declaration in package.json points towards ECMAScript 6 binaries. Eventually all JavaScript engines will support the entirety of the ECMAScript 6 specification in full. And it's actually tools like Webpack or Rollup that are behind and it's a bad idea to compromise the integrity of the package for tools that may not be relevant in a couple of months from now, given the ecosystem's rapid pace of migration to new tools when they happen 😉

If you want ES5 code with ES2015 modules, Funfix packages already come with such a compiled binary. So instead of ...

import * as ff from "funfix"

import { Try } from "funfix-core"

All you need to do is to give it a path to /dist/es5:

import * as ff from "funfix/dist/es5"

import { Try } from "funfix-core/dist/es5"

This will keep tools like Webpack happy.

[kayneb]

Ah I didn't realize that file had ES6 exports still. Yeah that makes sense. Thanks.

[codecov]

Codecov Report

Merging #114 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #114    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files          17     17            
  Lines        2197   2350   +153     
  Branches      422    442    +20     
======================================
+ Hits         2197   2350   +153

Impacted Files	Coverage Δ
packages/funfix-exec/src/future.ts	100% <0%> (ø)	⬆️
packages/funfix-exec/src/time.ts	100% <0%> (ø)	⬆️
packages/funfix-core/src/disjunctions.ts	100% <0%> (ø)	⬆️
packages/funfix-exec/src/ref.ts	100% <0%> (ø)	⬆️
packages/funfix-exec/src/scheduler.ts	100% <0%> (ø)	⬆️
packages/funfix-core/src/errors.ts	100% <0%> (ø)	⬆️
packages/funfix-effect/src/eval.ts	100% <0%> (ø)	⬆️
packages/funfix-effect/src/io.ts	100% <0%> (ø)	⬆️
packages/funfix-exec/src/cancelable.ts	100% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09bb885...eb47e39. Read the comment docs.

[alexandru]

Cool. So the /dist/es5 bundle is there precisely to deal with Webpack et all. If you have problems with that, open another issue to discuss it.

Also happily accepting other PRs 🙂