Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new Connect flows #98

Closed
hstove opened this issue May 23, 2022 · 2 comments
Closed

Support new Connect flows #98

hstove opened this issue May 23, 2022 · 2 comments

Comments

@hstove
Copy link
Contributor

hstove commented May 23, 2022

I think @kyranjamie could provide more details, but there have been some recent changes to @stacks/connect to support signing in using a ledger device. This relates to signing the JWT used in transactionRequest and similar calls to the web wallet, and the app doesn't have appPrivateKey in that instance.

Relevant commit in Connect: hirosystems/connect@e7aae49

I'm not super familiar with the latest on this, I just wanted to post this as a placeholder and FYI. More details in this thread: leather-wallet/extension#951 (comment)

@kyranjamie
Copy link

👋🏼 @hstove

I never dug too much into the implementation, but it was this getKeys(userSession) call that caused problems, throwing an exception when there's no private key. I'd consider this commit a bit of a workaround than a proper fix, where we just create unsigned JWTs.

My hope is that, with progress made the wallet protocol SIPs, and an implementation of the EIP-1102 style stx_requestAccounts, we can update the underlying implementation of transactionRequest to avoid use of JWTs altogether.

@aulneau
Copy link
Contributor

aulneau commented Jul 9, 2022

This is resolved with 0.6.1 of micro-stacks, and @micro-stacks/client@beta, @micro-stacks/react support these flows.

@aulneau aulneau closed this as completed Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants