Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page is hanging when I try to highlight text #76

Open
3 tasks
techiexplorer opened this issue Feb 14, 2021 · 2 comments
Open
3 tasks

Page is hanging when I try to highlight text #76

techiexplorer opened this issue Feb 14, 2021 · 2 comments
Labels
invalid This doesn't seem right

Comments

@techiexplorer
Copy link

This issue is:

  • Bug report
  • Feature request
  • Improvement

Actual behaviour

Page is hanging when I try to highlight text

Expected behaviour

Text should be highlighted

Steps to reproduce

new TextHighlighter(elem, {
color: "red"
});

Screenshots

Logs

  • attach export from options screen. Can replace urls and repo names used.

Configuration

PopOS (Linux), Latest chrome browser - Version 88.0.4324.150 (Official Build) (64-bit)

  • OS:
  • Browser:
  • Browser version:
@lastlink
Copy link
Collaborator

lastlink commented Aug 9, 2021

@techie-explorer there is not enough information to help with this? what's the html code? more information on the javascript being used.

@lastlink lastlink added the invalid This doesn't seem right label Aug 9, 2021
@jeffreybiles
Copy link

jeffreybiles commented Sep 25, 2021

I encountered really bad hanging issues in iOS (from several minutes all the way to full app crash).

Mine would always freeze when an image was included in the highlight.

I mostly fixed it by changing the keepRange boolean in doHighlight to false. Now it only occasionally freezes when highlights include an image.

I don't understand the mechanism for why this happens, but hopefully it can shed light on any other issues people might be having.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants