Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more positioning arguments #12

Merged
merged 4 commits into from Jun 20, 2023
Merged

Add more positioning arguments #12

merged 4 commits into from Jun 20, 2023

Conversation

rcannood
Copy link
Collaborator

Solution for #7.

Allows overriding arguments related to positioning of elements in the funky_heatmap.

@rcannood rcannood changed the title Add_position_args Add more positioning arguments May 20, 2023
@rcannood rcannood requested a review from artuurC May 20, 2023 06:40
@rcannood
Copy link
Collaborator Author

Hey @artuurC and @LouiseDck. I want to add this helper function to group together arguments related to positioning of elements in the funky heatmap. Do you think these changes are a good idea? If so, can we apply the same changes to funkyheatmappy?

@rcannood
Copy link
Collaborator Author

Alternatively, we might decide to include many more args into this argument list helper function. WDYT

@LouiseDck
Copy link
Contributor

I think these arguments are fine.
At first glance I think these are the ones people might want to change most often. If this is not the case, it's relatively painless to add them.
The defaults stay the same, which is good.
I foresee no issues implementing this in the python version.

@rcannood rcannood merged commit 9d6ee08 into main Jun 20, 2023
11 checks passed
@rcannood rcannood deleted the add_position_args branch June 20, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants