Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor legends #23

Merged
merged 20 commits into from Aug 27, 2023
Merged

Refactor legends #23

merged 20 commits into from Aug 27, 2023

Conversation

rcannood
Copy link
Collaborator

@rcannood rcannood commented Jul 14, 2023

Changes

  • Overhaul of the way legends are plotted (Refactor legends #23). Legends are now separate ggplots, the positioning of which is solved via patchwork.

  • Allow customizing legends using the legend argument in funky_heatmap() (Refactor legends #23).

This is what the MRE currently looks like:

plot

Future work:

  • Implement legends for images

@rcannood rcannood mentioned this pull request Jul 14, 2023
@rcannood rcannood marked this pull request as ready for review August 27, 2023 18:44
@rcannood rcannood merged commit c0ef43f into main Aug 27, 2023
11 checks passed
@rcannood rcannood deleted the refactor_legends branch August 27, 2023 18:51
@rcannood
Copy link
Collaborator Author

@mxposed @LouiseDck @artuurC I just merged this PR, which overhauls the way legends are rendered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant