Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow separate colour and size #25

Merged
merged 23 commits into from Sep 1, 2023
Merged

Allow separate colour and size #25

merged 23 commits into from Sep 1, 2023

Conversation

rcannood
Copy link
Collaborator

@rcannood rcannood commented Aug 27, 2023

Describe your changes

Issue ticket number and link

Closes #9
Closes #29

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@rcannood rcannood changed the title Separate colour from size Allow separate colour and size Sep 1, 2023
@rcannood rcannood marked this pull request as ready for review September 1, 2023 20:10
@rcannood
Copy link
Collaborator Author

rcannood commented Sep 1, 2023

In the end, I named the columns in column_info id_colour (or id_color) and id_size, because if I named them colour/color and size they might clash with already existing arguments and internal data. Will be merging this branch soon if no comments from @mxposed @LouiseDck @artuurC.

@lazappi I made a few more changes to make the figure produced by funkyheatmap more similar to the scib figure. Legends for images and bars are not supported yet (see #24 and #28, respectively), but I think the result is already a lot better. Let me know if you'd like to see other things changed.

Screenshot from 2023-09-01 22-12-19

@rcannood rcannood merged commit 1d3e61a into main Sep 1, 2023
11 checks passed
@rcannood rcannood deleted the separate_color_column branch September 1, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant