New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow separate colour and size #25
Conversation
…for geom `"bar"` (#25).
In the end, I named the columns in @lazappi I made a few more changes to make the figure produced by funkyheatmap more similar to the scib figure. Legends for images and bars are not supported yet (see #24 and #28, respectively), but I think the result is already a lot better. Let me know if you'd like to see other things changed. |
Describe your changes
Allow specifying different columns in
data
for determining the colour and size of the geom usingid_colour
andid_size
, respectively (Allow separate colour and size #25).Allow turning off bar outlines using
draw_outline
equal toFALSE
for geom"bar"
(Allow separate colour and size #25).Issue ticket number and link
Closes #9
Closes #29
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!