Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Favorite" markers #71

Closed
mf35 opened this issue Apr 18, 2021 · 2 comments
Closed

"Favorite" markers #71

mf35 opened this issue Apr 18, 2021 · 2 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@mf35
Copy link

mf35 commented Apr 18, 2021

Describe the bug
Adding a marker of the "favorite" type, doesn't put the marker in the right place on the timeline.

To Reproduce
Steps to reproduce the behavior:

  1. It happens everytime i open a video on the video player, then i choose to add a marker then choose "favorite" (heart icon)
    I tried it on several videos, the marker is put at the beginning of the timeline, or somewhere else. I can't find the logic behind this bug.
  2. It happens if the video is paused or playing. No difference.

Expected behavior
The marker should be put where the cursor is on the timeline.

Desktop (please complete the following information):

  • OS: Windows 10 (last patch)
  • App Version 0.8.0 (Angela)
@mf35 mf35 added the bug Something isn't working label Apr 18, 2021
@mf35
Copy link
Author

mf35 commented Apr 18, 2021

Ok i found that sometimes it puts the favorite marker at the same time stamp of the last marker i assigned (tag marker in this case), even though my timeline cursor is further.

To be clear an example:
I put a tag marker at 09:01 timestamp.
Then video goes on, at 09:45 i pause it to put a favorite marker: and marker is put at 09:01.

@fupdec fupdec added this to To do in Roadmap via automation Apr 18, 2021
@fupdec
Copy link
Owner

fupdec commented Apr 18, 2021

Thanks for the detailed description.

@fupdec fupdec closed this as completed Apr 19, 2021
Roadmap automation moved this from To do to Done Apr 19, 2021
@fupdec fupdec moved this from Done to Released in Roadmap Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Roadmap
  
Released
Development

No branches or pull requests

2 participants