Create pick date and time screen's ui components and implement related functionalities #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 16, 2022 13:19
Create pick date and time module folders, contract file, appointment request and station info entities and pick date and time view layer
Create socket table view helper and time slot table view cell and create extension to notification name class for simplifying the notification process. Refactor pick date and time contract file for deleting did select time slot method's stationID parameter because it is not necessary to send it from view layer and refactor connections of third socket stack view elements with the new names.
Add initializations of table view helpers functionality to pick date and time view layer
Create rest of the layers in pick date and time module
…uter Create pick date and time contract helper class for binding all the layers together and refactor station search router for navigating from station search view to pick date and time view. Refactor pick date and time presenter to send data to view layer in main thread instead of background thread and refactor pick date and time view layer for handling station name property value may come longer than expected due to coming from web service.
Refactor pick date and time view by first changing set navigation title view method's implementation by using only stack view instead of putting it in ui view because it is not necessary therefore also change the name of the method and call it again in did set property observer of station name since it comes from server and it might take longer than we expect and change the font size of components with adding constraint to stack view. Refactor socket table view helper to add keeping selected cell's index path and assigning background and border color of the time slot cell according to that and change time slot cell for deleting set selected functionality inside the method of set selected because from now on it is handled by socket table view handler and rest of the arrangements to make ui similar as much as possible to zeplin guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create pick date and time screen's ui components and implement related functionalities to make it work with rest of the project and refactor station search router for enabling navigation from station search view to pick date and time view. Text field design and picking date with date picker functionality will be implemented after next screen is completed.