Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to set the ListView scroll physics #1

Merged
merged 1 commit into from Mar 25, 2019

Conversation

JJCLane
Copy link
Contributor

@JJCLane JJCLane commented Mar 11, 2019

This is necessary when using the TimeLine within a Column and when shrinkWrap is set to true, otherwise you can't get the correct scrolling behaviour.

This is necessary when using the TimeLine within a Column and when shrinkWrap is set to true, otherwise you can't get the correct scrolling behaviour.
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #1 into master will decrease coverage by 1.36%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
- Coverage   99.53%   98.16%   -1.37%     
==========================================
  Files           4        4              
  Lines         214      218       +4     
==========================================
+ Hits          213      214       +1     
- Misses          1        4       +3
Impacted Files Coverage Δ
lib/timeline.dart 100% <100%> (ø) ⬆️
lib/src/timeline_painter.dart 96.59% <0%> (-3.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 126f420...33e81d5. Read the comment docs.

@furkantektas furkantektas merged commit ab00ac9 into furkantektas:master Mar 25, 2019
@furkantektas
Copy link
Owner

Yes it was needed, indeed. Thanks @JJCLane :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants