Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary batch update maybe? #203

Open
iofreddy85 opened this issue Feb 22, 2018 · 0 comments
Open

Unnecessary batch update maybe? #203

iofreddy85 opened this issue Feb 22, 2018 · 0 comments

Comments

@iofreddy85
Copy link

Is this line really needed?

@set-state {}, callback

If the on-p-change callback is fired, then it will trigger a re-render of the parent which will update the props so this setState seems to be unnecessary.

Am I missing something here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant