Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildScoreCache: doesn't work with defn.res and which.nodes provided together #52

Open
matteodelucchi opened this issue Feb 25, 2024 · 0 comments
Open

buildScoreCache: doesn't work with defn.res and which.nodes provided together #52

matteodelucchi opened this issue Feb 25, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@matteodelucchi
Copy link
Contributor

Because there is no test that handles this situation properly, defn.res and which.nodes provided together results in an error. https://github.com/furrer-lab/devel-abn/blob/40dc1e44269bac02adfc65ca9a4b489ebe017229/abn/R/build_score_cache.R#L590-L603

Resolve by checking if defn.res and which.nodes are not mismatching and keep if ok.
@matteodelucchi matteodelucchi transferred this issue from another repository Apr 9, 2024
@matteodelucchi matteodelucchi transferred this issue from furrer-lab/shuttle-abn Apr 9, 2024
@matteodelucchi matteodelucchi added the good first issue Good for newcomers label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matteodelucchi