Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clock inputs of FF25 register need to be inverted one more time #65

Open
msinger opened this issue Nov 13, 2021 · 2 comments
Open

Clock inputs of FF25 register need to be inverted one more time #65

msinger opened this issue Nov 13, 2021 · 2 comments

Comments

@msinger
Copy link

msinger commented Nov 13, 2021

On page 9, the DTFFs of register FF25 (NR51) should have their clock inputs inverted one more time. Either by adding a little circle to the clock inputs of the flip-flops, or by doing it like you did for register FF24 (NR50) to the left of this one: Drawing a second inverter and basically giving the two "COMP CLOCK" cells a proper name.

@msinger
Copy link
Author

msinger commented Nov 13, 2021

Same goes for register FF10 (NR10) on page 11.

@msinger
Copy link
Author

msinger commented Nov 13, 2021

And FF17 (NR22) on page 14. Only the upper five flip-flops are missing an inverter at their clock inputs. You already gave that inverter a name in Inkscape (ELAS), but you didn't put it into the schematics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant