Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utiltiy function to use Hexadecimal color code #216

Conversation

namanbansalcodes
Copy link
Contributor

This function will allow users to use hexadecimal color throughout FURY instead of rgb.

Type: Enhancement
Improves: User usability.

@pep8speaks
Copy link

pep8speaks commented Mar 24, 2020

Hello @namanb009! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 930:80: E501 line too long (80 > 79 characters)

Line 597:5: E265 block comment should start with '# '

Comment last updated at 2020-03-26 07:48:44 UTC

@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #216 into master will decrease coverage by 0.11%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   88.63%   88.51%   -0.12%     
==========================================
  Files          17       17              
  Lines        4347     4354       +7     
  Branches      547      548       +1     
==========================================
+ Hits         3853     3854       +1     
- Misses        354      360       +6     
  Partials      140      140
Impacted Files Coverage Δ
fury/utils.py 88.08% <14.28%> (-1.46%) ⬇️

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @namanb009,

That is a really cool and useful feature! See below my comment.

Thank you

fury/utils.py Outdated Show resolved Hide resolved
fury/utils.py Outdated Show resolved Hide resolved
fury/utils.py Outdated Show resolved Hide resolved
@skoudoro skoudoro added this to the v0.5.0 milestone Mar 24, 2020
@namanbansalcodes
Copy link
Contributor Author

@skoudoro The utils.py file in this branch just went missing, I don't know-how. So I added it again on my own and now I'm stuck
Can you help me out here?

@skoudoro
Copy link
Contributor

Hi @namanb009,

it looks like you renamed utils.py to colormap.py. What you should do is:

  • go to the folder where there is setup.py
  • git remove colormap.py
  • cd fury
  • git checkout utils.py
  • git push

and you should be ok

@skoudoro skoudoro modified the milestones: v0.5.0, v0.6.0 Apr 1, 2020
@namanbansalcodes namanbansalcodes deleted the namanb009-hex-color-util branch April 9, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants