New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utiltiy function to use Hexadecimal color code #216
Utiltiy function to use Hexadecimal color code #216
Conversation
Hello @namanb009! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-03-26 07:48:44 UTC |
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
- Coverage 88.63% 88.51% -0.12%
==========================================
Files 17 17
Lines 4347 4354 +7
Branches 547 548 +1
==========================================
+ Hits 3853 3854 +1
- Misses 354 360 +6
Partials 140 140
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @namanb009,
That is a really cool and useful feature! See below my comment.
- Can you move this function from
fury.utils
tofury.colormap
? - Can you add some unittests? look at https://github.com/fury-gl/fury/blob/master/fury/tests/test_colormap.py#L11
Thank you
- Added fnc to colormap - Changed fnc name - Fnc now returns np.array()
@skoudoro The utils.py file in this branch just went missing, I don't know-how. So I added it again on my own and now I'm stuck |
Hi @namanb009, it looks like you renamed
and you should be ok |
This function will allow users to use hexadecimal color throughout FURY instead of rgb.
Type: Enhancement
Improves: User usability.