New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pybullet examples #236
Pybullet examples #236
Conversation
Hello @kakashihatakae! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-04-21 23:19:45 UTC |
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
==========================================
+ Coverage 88.40% 88.69% +0.28%
==========================================
Files 17 17
Lines 4244 4387 +143
Branches 529 553 +24
==========================================
+ Hits 3752 3891 +139
- Misses 354 356 +2
- Partials 138 140 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kakashihatakae,
Thank you for this tutorial! See below some comment:
- A folder named "Examples" already exists as you can see here. Can you move this tutorial in the right place?
- This tutorial needs more explanation. you can look at this tutorial for example. Can you add a title and more comment.
- The name of your file is terrible. Can you rename it ? something like
intro_to_physics.py
orbasic_bullet_integration.py
.
Thank you!
Hello @skoudoro , the simulation depicted in this PR was a different one. Do you want me to update this PR later on? |
No, it is not necessary, but thank you @Nibba2018! Let's focus on scrollbar and filedialog. |
I have added a folder by the name "examples" that has the demo.
Link to the demo :- https://youtu.be/xCsCNCFtxbg