Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pybullet examples #236

Closed
wants to merge 5 commits into from
Closed

Conversation

kakashihatakae
Copy link
Contributor

I have added a folder by the name "examples" that has the demo.
Link to the demo :- https://youtu.be/xCsCNCFtxbg

@pep8speaks
Copy link

pep8speaks commented Apr 10, 2020

Hello @kakashihatakae! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 108:1: E302 expected 2 blank lines, found 1
Line 130:1: W293 blank line contains whitespace
Line 139:5: E303 too many blank lines (2)

Line 14:1: E302 expected 2 blank lines, found 1
Line 18:1: E265 block comment should start with '# '
Line 19:1: E305 expected 2 blank lines after class or function definition, found 1
Line 19:28: E251 unexpected spaces around keyword / parameter equals
Line 19:30: E251 unexpected spaces around keyword / parameter equals
Line 19:53: W291 trailing whitespace
Line 20:39: E231 missing whitespace after ','
Line 20:41: E231 missing whitespace after ','
Line 20:46: W291 trailing whitespace
Line 23:37: E127 continuation line over-indented for visual indent
Line 25:33: E127 continuation line over-indented for visual indent
Line 30:44: E201 whitespace after '['
Line 30:55: E202 whitespace before ']'
Line 32:1: W293 blank line contains whitespace
Line 33:1: E265 block comment should start with '# '
Line 35:26: E127 continuation line over-indented for visual indent
Line 35:45: E231 missing whitespace after ','
Line 36:26: E127 continuation line over-indented for visual indent
Line 36:44: E203 whitespace before ','
Line 37:26: E127 continuation line over-indented for visual indent
Line 41:36: E127 continuation line over-indented for visual indent
Line 45:44: E201 whitespace after '['
Line 45:55: E202 whitespace before ']'
Line 63:16: E225 missing whitespace around operator
Line 67:26: E128 continuation line under-indented for visual indent
Line 67:54: E231 missing whitespace after ','
Line 68:26: E128 continuation line under-indented for visual indent
Line 68:46: E203 whitespace before ','
Line 69:26: E128 continuation line under-indented for visual indent
Line 69:49: E231 missing whitespace after ','
Line 72:9: E265 block comment should start with '# '
Line 77:45: E127 continuation line over-indented for visual indent
Line 78:45: E127 continuation line over-indented for visual indent
Line 78:75: E231 missing whitespace after ','
Line 82:80: E501 line too long (81 > 79 characters)
Line 83:53: E201 whitespace after '['
Line 83:64: E202 whitespace before ']'
Line 104:35: E127 continuation line over-indented for visual indent
Line 105:35: E127 continuation line over-indented for visual indent
Line 106:35: E127 continuation line over-indented for visual indent
Line 108:23: W291 trailing whitespace
Line 122:1: W293 blank line contains whitespace
Line 128:1: W293 blank line contains whitespace
Line 132:1: W293 blank line contains whitespace
Line 139:1: W293 blank line contains whitespace
Line 146:72: W292 no newline at end of file
Line 146:72: W292 no newline at end of file
Line 146:72: W292 no newline at end of file

Comment last updated at 2020-04-21 23:19:45 UTC

@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #236 into master will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   88.40%   88.69%   +0.28%     
==========================================
  Files          17       17              
  Lines        4244     4387     +143     
  Branches      529      553      +24     
==========================================
+ Hits         3752     3891     +139     
- Misses        354      356       +2     
- Partials      138      140       +2     
Impacted Files Coverage Δ
fury/window.py 83.37% <0.00%> (-1.10%) ⬇️
fury/actor.py 92.76% <0.00%> (+0.13%) ⬆️
fury/colormap.py 93.91% <0.00%> (+0.14%) ⬆️
fury/io.py 78.12% <0.00%> (+0.34%) ⬆️
fury/ui.py 86.28% <0.00%> (+0.49%) ⬆️
fury/utils.py 90.02% <0.00%> (+1.37%) ⬆️
fury/testing.py 90.90% <0.00%> (+1.62%) ⬆️
fury/primitive.py 85.71% <0.00%> (+2.19%) ⬆️

@skoudoro skoudoro added this to the v0.6.0 milestone Apr 10, 2020
Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kakashihatakae,

Thank you for this tutorial! See below some comment:

  • A folder named "Examples" already exists as you can see here. Can you move this tutorial in the right place?
  • This tutorial needs more explanation. you can look at this tutorial for example. Can you add a title and more comment.
  • The name of your file is terrible. Can you rename it ? something like intro_to_physics.py or basic_bullet_integration.py.

Thank you!

@skoudoro skoudoro modified the milestones: v0.6.0, v0.7.0 May 25, 2020
@skoudoro skoudoro modified the milestones: v0.7.0, 0.6.1 Aug 17, 2020
@Nibba2018 Nibba2018 mentioned this pull request Aug 17, 2020
4 tasks
@Nibba2018
Copy link
Member

Hello @skoudoro , the simulation depicted in this PR was a different one. Do you want me to update this PR later on?

@skoudoro
Copy link
Contributor

No, it is not necessary, but thank you @Nibba2018! Let's focus on scrollbar and filedialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants