moved physics tutorials to examples under the heading 'Integrate physics using pybullet'

[tushar5526]

#297
Moved all the Physics tutorials under examples section with a heading 'Integrate physics using pybullet'

Fixed the buggy wrecking ball behavior, the problem was radii was the links or rope's radius instead of the wrecking ball. Changing it to 1 was making a cylindrical collider of radius 1 greater than wrecking ball's radius hence the bug.
Ball's radius was hardcoded to 0.2, assigned it to the variable ball_radius so now you can mess with wrecking ball by changing the radius.
Fixed some typos that I found along with it.

PS : There was some weird behavior after 100 simulation steps. The ball went crazy and there were some weird stretched lines instead of ropes, I think the code to make the rope has to be redone.

[Nibba2018]

Hello @tushar5526 , Thank you for creating this PR. As you are currently working on the physics examples, I would request you to work on this problem so that we can close #298 as well.

[skoudoro]

Hi @tushar5526,

Thank you for doing this!

+1 with @Nibba2018 request
Furthermore, can you add pybullet in the requirements/docs.txt?

Thank you

[tushar5526]

Sure @Nibba2018 @skoudoro :)

[Nibba2018]

Also a quick note regarding the installation of pybullet. Most windows versions may or may not have the appropriate wheels for pybullet. Therefore, pip install pybullet will throw an error, and in order to fix that one must install Windows SDK using Visual Studio Build Tools from here.

The same problem doesn't occur for Linux or mac os. So no issues with that.

[tushar5526]

@Nibba2018 Thanks, I work on Ubuntu 18.04 LTS so no issues

[Nibba2018]

Which section do you think is appropriate to add this information @skoudoro ?

[tushar5526]

Any version barrier with pybullet @Nibba2018 ?

[Nibba2018]

That's a very hard question to answer as I was never able to find any changelogs for pybullet. But anything above 2.7.0 should work fine.

[skoudoro]

Which section do you think is appropriate to add this information @skoudoro ?

Many packages have this issue when they have a C or cython dependencies. I think it is ok. No need to add this information until we decide that is a mandatory dependency.

[codecov]

Codecov Report

Merging #302 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #302   +/-   ##
=======================================
  Coverage   88.64%   88.64%           
=======================================
  Files          21       21           
  Lines        5073     5073           
  Branches      656      656           
=======================================
  Hits         4497     4497           
  Misses        406      406           
  Partials      170      170           

[tushar5526]

@Nibba2018 No output on running viz_wrecking_ball.py. When I am running it a screen flashes for 0.5 seconds and then the program exits, plus a png file is created that is completely black. No errors or warnings in the console.
pybullet==2.8.7 ( latest version )

[Nibba2018]

@tushar5526 Have you set the value of interactive to True? Also, you need to increase the simulation step limit(if cnt == 2000) to view the entire simulation. The limit was purposefully set to a lower value for doc generation.

[tushar5526]

Thanks @Nibba2018 works good !

[pep8speaks]

Hello @tushar5526! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file docs/examples/physics_using_pybullet/viz_chain.py:

Line 39:80: E501 line too long (80 > 79 characters)

• In the file docs/examples/physics_using_pybullet/viz_wrecking_ball.py:

Line 95:80: E501 line too long (86 > 79 characters)
Line 118:80: E501 line too long (80 > 79 characters)

Comment last updated at 2020-08-25 04:26:15 UTC

[tushar5526]

Fixed the buggy wrecking ball behavior, the problem was radii was the links or rope's radius instead of the wrecking ball. Changing it to 1 was making a cylindrical collider of radius 1 greater than wrecking ball's radius hence the bug.
Ball's radius was hardcoded to 0.2, assigned it to the variable ball_radius so now you can mess with wrecking ball by changing the radius.
Fixed some typos that I found along with it.

PS : There was some weird behaviour after 100 simulation steps. The ball went crazy and I was having weird stretched lines instead of ropes, I think the code to make the rope has to be redone.

@Nibba2018 @skoudoro

[skoudoro]

Great job @tushar5526! do not forget to address the pep8 above

[tushar5526]

Do you want the commits to be squashed or is it ok ? @skoudoro

[skoudoro]

No need to squash

[skoudoro]

Hi @tushar5526,

Your PR is almost ready to go. I just generate the documentation and see below the last issue.
After your fixes, we can merge it.

Thank you for this last update

[tushar5526]

Thanks, @skoudoro for checking it out, made the changes, and also ran pep8 on other physics demos files.

[skoudoro]

Thank you @tushar5526. Merging