Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipping overflowing text from the left. #308

Closed
Nibba2018 opened this issue Sep 15, 2020 · 14 comments · Fixed by #337
Closed

Clipping overflowing text from the left. #308

Nibba2018 opened this issue Sep 15, 2020 · 14 comments · Fixed by #337
Assignees
Labels
🍺 Hacktoberfest 🍺 Support open source and Start Hacking ! good first issue Good for newcomers type:Enhancement

Comments

@Nibba2018
Copy link
Member

Nibba2018 commented Sep 15, 2020

The current implementation of clip_overflow in fury.ui allows us to clip overflowing text from the right end for a given width. It will be helpful to have a feature that can clip overflowing text from the left end as well. The overflowing text must be replaced by .... This feature will be helpful while developing FileDialog2D.

For e.g
if extraordinary overflows for a given width then it must be replaced by ...ordinary where ...ordinary is the perfect fit for that width.

@Nibba2018 Nibba2018 added 🍺 Hacktoberfest 🍺 Support open source and Start Hacking ! good first issue Good for newcomers type:Enhancement labels Sep 15, 2020
@tushar5526
Copy link
Contributor

Issues with hacktoberfest tags has to be solved in october only ? :p

@Nibba2018
Copy link
Member Author

Yes @tushar5526 , If you create PRs before October then they wont be eligible for Hacktoberfest.

@rishigarg94
Copy link

can I work on this issue pls?

@Nibba2018
Copy link
Member Author

Hey @rishigarg94 , @tushar5526 claimed it first so if he plans to work on some other issue then I will assign this to you.

Also @tushar5526 , aren't you planning to work on #313 ?

@rishigarg94
Copy link

Hey @rishigarg94 , @tushar5526 claimed it first so if he plans to work on some other issue then I will assign this to you.

Also @tushar5526 , aren't you planning to work on #313 ?

sure

@tushar5526
Copy link
Contributor

Yes @Nibba2018, I am done with #313 will submit a PR soon.

@rishigarg94
Copy link

can you pls explain with some example... it is not clear what you wnat to do,

like, do you want "extraordinary" to be display as "...ordinary" ?
in case of width limit reach?
or something else?

@Nibba2018
Copy link
Member Author

Great @tushar5526 , then I am assigning this issue to @rishigarg94 .

Yes exactly @rishigarg94 . The entire string ...ordinary should be a perfect fit for the given width.

@rishigarg94
Copy link

Great @tushar5526 , then I am assigning this issue to @rishigarg94 .

Yes exactly @rishigarg94 . The entire string ...ordinary should be a perfect fit for the given width.

yes thanks for assigning me...
means, you don't wnat "extraordinary" to be shown as "extr..." you want it to be "...ary"? like this?

@Nibba2018
Copy link
Member Author

yes thanks for assigning me...
means, you don't wnat "extraordinary" to be shown as "extr..." you want it to be "...ary"? like this?

Yes @rishigarg94

@rishigarg94
Copy link

yes thanks for assigning me...
means, you don't wnat "extraordinary" to be shown as "extr..." you want it to be "...ary"? like this?

Yes @rishigarg94

ok sure

@Nibba2018
Copy link
Member Author

@rishigarg94 Updates?

@tushar5526
Copy link
Contributor

@Nibba2018 Can I do it ?

@Nibba2018
Copy link
Member Author

@tushar5526 sure, go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍺 Hacktoberfest 🍺 Support open source and Start Hacking ! good first issue Good for newcomers type:Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants