Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cylinder primitive generation #318

Closed
skoudoro opened this issue Sep 30, 2020 · 6 comments · Fixed by #328
Closed

Cylinder primitive generation #318

skoudoro opened this issue Sep 30, 2020 · 6 comments · Fixed by #328
Assignees
Labels
🍺 Hacktoberfest 🍺 Support open source and Start Hacking ! good first issue Good for newcomers type:New Feature
Milestone

Comments

@skoudoro
Copy link
Contributor

It would be good to have a function that generates the vertices and triangles of a cylinder.

Primitives examples are available here.

@skoudoro skoudoro added good first issue Good for newcomers 🍺 Hacktoberfest 🍺 Support open source and Start Hacking ! labels Sep 30, 2020
@skoudoro skoudoro added this to the v0.8.0 milestone Sep 30, 2020
@tushar5526
Copy link
Contributor

tushar5526 commented Oct 1, 2020

@skoudoro I would like to do it. Can you brief a little, do you want the vertices and triangles of capped and uncapped cylinders too?

@skoudoro
Copy link
Contributor Author

skoudoro commented Oct 1, 2020

Great! Thanks @tushar5526.

If we could have both, it would be perfect! Just add a boolean option/parameter capped.

@skoudoro skoudoro modified the milestones: v0.8.0, v0.7.0 Oct 1, 2020
@tushar5526
Copy link
Contributor

Great! I will be referring to this code from p5py ( processing for python )

@skoudoro
Copy link
Contributor Author

skoudoro commented Oct 1, 2020

We try to avoid adding a dependency when it is not necessary so you can reimplement it and refer to this code on the docstring but do not import this package, please 😄 (even if it is a good one though)

@skoudoro
Copy link
Contributor Author

skoudoro commented Oct 1, 2020

Furthermore, the GPL License from p5py is problematic for us.

So you should avoid copy code or import the package. You will need to reimplement it @tushar5526

@tushar5526
Copy link
Contributor

@skoudoro Yes, I will be not importing the package, by referencing I meant the algorithm to generate the vertices & triangles (if that's not an issue ).
Thank you for pointing out the GPL license, I will keep that in mind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍺 Hacktoberfest 🍺 Support open source and Start Hacking ! good first issue Good for newcomers type:New Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants