Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor error in documentation of create_colormap function #363

Closed
SunTzunami opened this issue Jan 25, 2021 · 2 comments · Fixed by #368
Closed

Minor error in documentation of create_colormap function #363

SunTzunami opened this issue Jan 25, 2021 · 2 comments · Fixed by #368

Comments

@SunTzunami
Copy link
Member

Description

This is with respect to the create_colormap function.

According to the comment describing the auto variable, if auto is True then v is interpolated to [0, 10] from v.min() to v.max(). In the actual code however, v is being interpolated to [0, 1] from v.min() to vmax(). I think that this can be fixed by either editing the comment to specify that v is interpolated from [0, 1] or by altering the code to interpolate v from [0, 10].

@ganimtron-10
Copy link
Contributor

I edited the Docs and Changed the docs according to your suggestion as I thought this way would be the Best and created a pull request...
My Pull Request

@skoudoro skoudoro linked a pull request Jan 31, 2021 that will close this issue
@skoudoro skoudoro added this to the v0.7.0 milestone Jan 31, 2021
@skoudoro
Copy link
Contributor

Thank you @SunTzunami, fixed by #368, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants