Added Special Character Support #369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoudoro
reviewed
Feb 1, 2021
There was a problem hiding this comment.
Hi @16bitmood,
Thank you for adding this feature! we will look into it and get back to you.
Nibba2018
requested changes
Feb 1, 2021
There was a problem hiding this comment.
Hi @16bitmood , thanks for creating this PR, I have tested various special characters and they work fine on TextBox2D.
But I don't understand your unit test. Please be a bit more elaborate. For me a window pops up and then quickly closes without any keystrokes.
I would suggest you to add some assertions at the end to test whether the key presses are correctly registered/saved or not. For e.g:
- type a string including printable characters.
- close the window.
- then assert if the message parameter contains the same string of the characters or not.
Thanks!
Comment on lines
+1904
to
1907
|
|
||
| def __init__(self, center=(0, 0), | ||
| initial_value=50, min_value=0, max_value=100, | ||
| length=200, line_width=5, |
There was a problem hiding this comment.
Are these extra new lines necessary?
Comment on lines
+2253
to
2255
|
|
||
| def __init__(self, line_width=5, inner_radius=0, outer_radius=10, | ||
| handle_side=20, center=(450, 300), length=200, |
There was a problem hiding this comment.
same as above and below few new lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special character support for textbox2d (like: '!@#$%^&*()')