Added an sdf for rendering a Capsule actor #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoudoro
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
Thank you for this @haran2001.
This is ready to go, so I am going ahead and merging this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, I noticed that fury lacked a primitive to render a capsule actor and have taken up the liberty to add an sdf for the same.
I took this up as an opportunity to expand the role of sdf's in the fury codebase.
I have also modified the existing tests and example tutorial to include the capsule actor.
This the final result.
All of the sdf based actors in fury so far
100 capsules rendered to check overall performance
I humbly request the maintainers to consider adding this new actor to the vast fury codebase.
Any feedback and suggestions are most welcome.
Thank You.