Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Propagate update_actor #387

Merged
merged 5 commits into from Feb 26, 2021
Merged

Conversation

skoudoro
Copy link
Contributor

This PR assures that we update all array when we call update_actor

fury/utils.py Outdated

def colors_from_actor(actor, array_name='colors'):

def colors_from_actor(actor, array_name='colors', as_vtk_type=False):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as_vtk or as_vtk_array

"""Update actor.

Parameters
----------
actor : actor
all_arrays: bool, optional
if False, only vertices are updated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if True ...

@Garyfallidis Garyfallidis merged commit 5248791 into fury-gl:master Feb 26, 2021
@Garyfallidis
Copy link
Contributor

Thank you @skoudoro. @filipinascimento please update your example to use update_actor. You should not need to call modified that often from now on.

@skoudoro skoudoro added this to the v0.7.0 milestone Feb 26, 2021
@skoudoro skoudoro deleted the fix-modified branch February 26, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants