New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the way we import external libraries by using only the necessary modules #470
Conversation
ca66a26
to
1b6f1e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
==========================================
+ Coverage 89.03% 89.21% +0.17%
==========================================
Files 33 34 +1
Lines 7112 7230 +118
Branches 836 836
==========================================
+ Hits 6332 6450 +118
Misses 547 547
Partials 233 233
|
This PR is ready to go. Can you have a look @Garyfallidis and @guaje? Thank you |
@skoudoro there is currently a conflict.
|
And then in fvtk.py we add the
In this way in the other scripts you can just do
Also what speedup do you see? |
c74218c
to
deeb865
Compare
7d0c7e6
to
c3c3386
Compare
This is great and much needed! a) update molecular.py file to use new gig. Thank you @skoudoro ! |
@skoudoro on your upcoming PR please also report timings. How much faster is importing in this new way than before? |
This PR is the beginning of #457.
The goal is to make our scripts load faster by importing only the functions/modules we need from VTK.