New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding numpy_to_vtk_image_data
method to utility
#509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ganimtron-10,
Overall, it looks good. Can you rebase your PR and address my comment?
It should be ready to be merged after that.
Thanks !
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
==========================================
+ Coverage 81.87% 81.88% +0.01%
==========================================
Files 54 54
Lines 10618 10643 +25
Branches 1069 1071 +2
==========================================
+ Hits 8693 8715 +22
- Misses 1661 1662 +1
- Partials 264 266 +2
|
Thank you for rebasing @ganimtron-10. Can you also address my comment above? (add spacing, origin, and deep as optional parameter) |
Hello @ganimtron-10! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-01-20 09:09:25 UTC |
Hi @skoudoro , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update. See Below for the last comment. Thanks @ganimtron-10
Hey @skoudoro , |
Thanks @ganimtron-10! merging |
Adding a
numpy_to_vtk_image_data
method in utility to ease the image loading process.Issue mentioned at #500 .
PTAL.
Thanks!