Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding numpy_to_vtk_image_data method to utility #509

Merged
merged 9 commits into from Jan 20, 2022

Conversation

ganimtron-10
Copy link
Contributor

Adding a numpy_to_vtk_image_data method in utility to ease the image loading process.
Issue mentioned at #500 .
PTAL.
Thanks!

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ganimtron-10,

Overall, it looks good. Can you rebase your PR and address my comment?

It should be ready to be merged after that.

Thanks !

fury/utils.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #509 (419be04) into master (d12f9ed) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 419be04 differs from pull request most recent head 44b8c1f. Consider uploading reports for the commit 44b8c1f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
+ Coverage   81.87%   81.88%   +0.01%     
==========================================
  Files          54       54              
  Lines       10618    10643      +25     
  Branches     1069     1071       +2     
==========================================
+ Hits         8693     8715      +22     
- Misses       1661     1662       +1     
- Partials      264      266       +2     
Impacted Files Coverage Δ
fury/fury/utils.py 85.20% <0.00%> (-0.13%) ⬇️
fury/fury/tests/test_utils.py 95.39% <0.00%> (+0.12%) ⬆️

@skoudoro
Copy link
Contributor

Thank you for rebasing @ganimtron-10. Can you also address my comment above? (add spacing, origin, and deep as optional parameter)

@pep8speaks
Copy link

pep8speaks commented Jan 19, 2022

Hello @ganimtron-10! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-01-20 09:09:25 UTC

@ganimtron-10
Copy link
Contributor Author

Hi @skoudoro ,
I was just facing issues with my local workspace so it took time to reflect the changes!
Now I have updated the function with optional parameters.
Let me know if it has any changes!
Thanks !

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update. See Below for the last comment. Thanks @ganimtron-10

fury/utils.py Show resolved Hide resolved
fury/utils.py Outdated Show resolved Hide resolved
@ganimtron-10
Copy link
Contributor Author

Hey @skoudoro ,
I have addressed all the comments, PTAL!
Thanks.

@skoudoro skoudoro merged commit 9514d71 into fury-gl:master Jan 20, 2022
@skoudoro
Copy link
Contributor

Thanks @ganimtron-10! merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants