Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing how we do things with our test suite. #515

Merged
merged 16 commits into from Jan 5, 2022

Conversation

Garyfallidis
Copy link
Contributor

@Garyfallidis Garyfallidis commented Dec 16, 2021

This PR aims to resolve multiple issues:

a) The circular import issue with DIPY. See also dipy/dipy#2493
b) Fixing the bad window issues we get from time to time during testing.
c) Solves an issue with windows staying open and not closing as fast as they should during tests.
d) Finally, this PR is also dealing with a segmentation fault issue that pytest has when running multiple files at once.
For more information see here pytest-dev/pytest#3672
Our current solution for the later is to run pytest on individual files. Pytest claims that this is an issue with software opening threads but this is to be seen.

@pep8speaks
Copy link

pep8speaks commented Dec 16, 2021

Hello @Garyfallidis! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 957:1: E302 expected 2 blank lines, found 1
Line 1160:9: E265 block comment should start with '# '

Line 126:5: E306 expected 1 blank line before a nested definition, found 0
Line 128:1: W293 blank line contains whitespace
Line 140:1: W293 blank line contains whitespace

Line 36:1: E302 expected 2 blank lines, found 1
Line 229:1: W293 blank line contains whitespace
Line 1407:1: W391 blank line at end of file

Line 13:80: E501 line too long (80 > 79 characters)

Line 268:1: E303 too many blank lines (3)
Line 351:5: E125 continuation line with same indent as next logical line
Line 383:1: W293 blank line contains whitespace

Line 311:1: W391 blank line at end of file

Line 127:1: W293 blank line contains whitespace
Line 361:39: W292 no newline at end of file
Line 361:39: W292 no newline at end of file
Line 361:39: W292 no newline at end of file

Line 22:1: W293 blank line contains whitespace

Line 497:1: W293 blank line contains whitespace
Line 559:1: W293 blank line contains whitespace
Line 564:1: W293 blank line contains whitespace

Comment last updated at 2022-01-05 18:37:08 UTC

@Garyfallidis Garyfallidis changed the title Relax dipy dependency Changing test suite Dec 23, 2021
@Garyfallidis Garyfallidis changed the title Changing test suite Changing how we do things with our test suite. Dec 23, 2021
@skoudoro skoudoro merged commit 6df3208 into fury-gl:master Jan 5, 2022
@skoudoro
Copy link
Contributor

skoudoro commented Jan 5, 2022

Thanks @Garyfallidis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants