Snapshot flipping bug fix #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Garyfallidis! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-01-14 18:18:04 UTC |
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
==========================================
- Coverage 89.55% 81.86% -7.69%
==========================================
Files 35 54 +19
Lines 7467 10616 +3149
Branches 857 1069 +212
==========================================
+ Hits 6687 8691 +2004
- Misses 547 1661 +1114
- Partials 233 264 +31 |
skoudoro
reviewed
Jan 14, 2022
fury/io.py
Outdated
| @@ -77,6 +78,7 @@ def load_image(filename, as_vtktype=False, use_pillow=True): | |||
| vtk_image.SetSpacing(1.0, 1.0, 1.0) | |||
| vtk_image.SetOrigin(0.0, 0.0, 0.0) | |||
| arr_tmp = np.flipud(image) | |||
There was a problem hiding this comment.
Can you remove this line? It is not used since you do arr_tmp = image in the line below (81)
|
Failing CI's not related, thank @Garyfallidis. merging |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue reported in #467
Basically, we were not flipping the images correctly in
save_imageandload_image.save_imagewas called bysnapshot.