New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cone actor needs to use repeat_primitives by default #529

Closed

skoudoro opened this issue Jan 21, 2022 · 1 comment · Fixed by #547

Labels

good first issue type:Enhancement

Contributor

skoudoro commented Jan 21, 2022

This will allow cone to have the same behavior when picking vertices or edges as with other primitives.

However, we should also keep repeat_sources as a secondary option just in case we need to use some of the other VTK filters.

See example of box actor (using repeat_primitives) here https://github.com/fury-gl/fury/blob/master/fury/actor.py#L1696

See current implementation of cone here https://github.com/fury-gl/fury/blob/master/fury/actor.py#L1829

skoudoro added good first issue type:Enhancement labels

Onkar627 commented Feb 6, 2022 •

edited

Can you guide me @skoudoro on how to proceed.

xtanion mentioned this issue

Cone actor uses repeat_primitive by default #547

Merged

skoudoro linked a pull request

that will close this issue

Cone actor uses repeat_primitive by default #547

Merged

skoudoro closed this as completed in #547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment