Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VTK_9_PLUS flag #536

Merged
merged 3 commits into from Jan 27, 2022
Merged

Remove VTK_9_PLUS flag #536

merged 3 commits into from Jan 27, 2022

Conversation

skoudoro
Copy link
Contributor

Currently, we are depending only on VTK 9.1.0 so this flag is not necessary anymore.

@pep8speaks
Copy link

pep8speaks commented Jan 27, 2022

Hello @skoudoro! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-01-27 17:33:34 UTC

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #536 (a34c4fe) into master (214375b) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
+ Coverage   81.89%   82.11%   +0.21%     
==========================================
  Files          54       54              
  Lines       10659    10627      -32     
  Branches     1067     1061       -6     
==========================================
- Hits         8729     8726       -3     
+ Misses       1667     1641      -26     
+ Partials      263      260       -3     
Impacted Files Coverage Δ
fury/fury/tests/test_material.py 11.00% <0.00%> (-1.09%) ⬇️
fury/fury/lib.py 100.00% <0.00%> (ø)
fury/fury/tests/test_deprecator.py 95.67% <0.00%> (+0.02%) ⬆️
fury/fury/material.py 31.34% <0.00%> (+1.34%) ⬆️
fury/fury/utils.py 89.16% <0.00%> (+3.17%) ⬆️
fury/fury/actors/peak.py 94.15% <0.00%> (+4.20%) ⬆️

@Garyfallidis Garyfallidis merged commit 4edfa34 into fury-gl:master Jan 27, 2022
@skoudoro skoudoro deleted the vtk91 branch October 13, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants