Changing dot actor #584
Changing dot actor #584
Conversation
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
==========================================
+ Coverage 87.95% 87.96% +0.01%
==========================================
Files 62 62
Lines 13030 13099 +69
Branches 1308 1316 +8
==========================================
+ Hits 11460 11522 +62
- Misses 1198 1201 +3
- Partials 372 376 +4
|
There was a problem hiding this comment.
@tvcastillod Thanks for this PR. The new dot actor looks promising. And the color_check function can benefit many actors. Here are some comments and sugestions.
There was a problem hiding this comment.
@tvcastillod thank you for applying the previously requested changes, the addition of the test_color_check function, and the unique check.
I've added some comments regarding the latest changes.
Additionally, you need to rebase the PR.
|
Hello @tvcastillod! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-05-17 02:20:22 UTC |
|
LGTM! Thanks @tvcastillod. Merging |
Hello, I made this PR in order to improve flexibility of the current dot actor. I changed
dotsactor to allow usage of multiple colors, so now it has the option to set a different color for each point created. For it to support both ndarray (N,3 or 4) and tuple (3 or 4,) I created a function called__color_checkto managecolorsdot's parameter. Additionally, as the actor includes anopacityparameter If a value is given, each dot will have the same opacity otherwise opacity is set to 1 by default, or is defined by Alpha parameter incolorsif given.