Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Week 3 BlogPost #611

Merged
merged 7 commits into from Jul 3, 2022
Merged

Adding Week 3 BlogPost #611

merged 7 commits into from Jul 3, 2022

Conversation

ganimtron-10
Copy link
Contributor

Adding Week 3 Blog Post

BlogPost Week3

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #611 (d33fa09) into master (541e7c1) will not change coverage.
The diff coverage is n/a.

❗ Current head d33fa09 differs from pull request most recent head b0e0add. Consider uploading reports for the commit b0e0add to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #611   +/-   ##
=======================================
  Coverage   51.84%   51.84%           
=======================================
  Files         105      105           
  Lines       22337    22337           
  Branches     2460     2460           
=======================================
  Hits        11581    11581           
  Misses      10381    10381           
  Partials      375      375           

Copy link
Contributor

@m-agour m-agour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ganimtron-10 ,
Nice and detailed post with no typos I believe.
I only have some minor punctuation-related suggestions.

@ganimtron-10
Copy link
Contributor Author

Thanks, @m-agour for the review!

Copy link
Member

@xtanion xtanion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ganimtron-10, This is a really nice blog. There are a few minor grammatical errors I mentioned below. PTAL

docs/source/posts/2022/2022-06-22-week-3-praneeth.rst Outdated Show resolved Hide resolved
docs/source/posts/2022/2022-06-22-week-3-praneeth.rst Outdated Show resolved Hide resolved
@ganimtron-10
Copy link
Contributor Author

Thank you @xtanion for the review!

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ganimtron-10, merging!

@skoudoro skoudoro merged commit fc9949d into fury-gl:master Jul 3, 2022
@ganimtron-10 ganimtron-10 deleted the week-3 branch July 4, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants