Week 3 blog post. #619
Merged
Week 3 blog post. #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganimtron-10
reviewed
Jul 4, 2022
There was a problem hiding this comment.
Hello @m-agour ,
Nice Blog. It generates well and is visible in blog.html too.
Mentioned some punctuation error I found.
Also if you could reduce the video size then it would be great as it kind of overlaps the On this page section on the right-hand side as shown in the image.
Thanks!
|
|
||
| - Composed the playback panel as a single component `PlaybackPanel` (slider does not function yet). | ||
|
|
||
| - As we tried to come up with a way to do keyframe animations on a partial subset of the actor's primitives not all of them, we found that there is no currently implemented way to get the primitives count of a single actor. So I made this PR `#617`_ so that the primitives' count is saved inside the polydata of the actor as suggested by Filipi and Javier so that the primitives' count can be used to distinguish the vertices of different primitives. |
There was a problem hiding this comment.
Maybe primitives instead of primitives'
There was a problem hiding this comment.
I meant here the count of the primitives
xtanion
reviewed
Jul 5, 2022
| What did you do this week? | ||
| -------------------------- | ||
|
|
||
| - Redesigned the keyframe animations API to optimize having a lot of timelines by composing them into a parent `Timeline` called `CompositeTimeline` while maintaining playing individual timelines seperately. |
|
Thank you @ganimtron-10 and @xtanion for your amazing reviews. |
skoudoro
reviewed
Jul 6, 2022
| This week I will do the following | ||
|
|
||
| - Finish up the ``PlaybackPanel``. | ||
| - Implement all other interpolators in GLSL (color interpolators included) |
There was a problem hiding this comment.
missing . at the end of the sentence
| - Finish up the ``PlaybackPanel``. | ||
| - Implement all other interpolators in GLSL (color interpolators included) | ||
| - Start Implementing slerp interpolation using quaternions in both Python and GLSL. | ||
| - Add tests for the Previous work. |
There was a problem hiding this comment.
Previous does not need to be capital
|
Thanks @m-agour, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My week 3 blog post.