Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding week 5 blog post #637

Merged
merged 4 commits into from Jul 21, 2022
Merged

Adding week 5 blog post #637

merged 4 commits into from Jul 21, 2022

Conversation

xtanion
Copy link
Member

@xtanion xtanion commented Jul 20, 2022

The blog is visible in blos.html
image

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #637 (50362aa) into master (26318ec) will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
+ Coverage   51.63%   52.00%   +0.37%     
==========================================
  Files         105      108       +3     
  Lines       22829    23596     +767     
  Branches     2531     2605      +74     
==========================================
+ Hits        11788    12272     +484     
- Misses      10657    10924     +267     
- Partials      384      400      +16     
Impacted Files Coverage Δ
fury/io.py 0.00% <0.00%> (ø)
fury/lib.py 0.00% <0.00%> (ø)
fury/actor.py 0.00% <0.00%> (ø)
fury/utils.py 0.00% <0.00%> (ø)
fury/window.py 0.00% <0.00%> (ø)
fury/fury/lib.py 100.00% <0.00%> (ø)
fury/transform.py 0.00% <0.00%> (ø)
fury/fury/window.py 83.25% <0.00%> (ø)
fury/ui/elements.py 0.00% <0.00%> (ø)
fury/fury/transform.py 100.00% <0.00%> (ø)
... and 15 more

Copy link
Contributor

@ganimtron-10 ganimtron-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @xtanion ,
Short and Nice Blog!! LGTM.
Thanks!

This week I'll be working on the following:

- Get the exporting PR merged by this week.
- Loading the animations (simple, morph, and skeletal) data as dictionaries from the glTF model so that It can be sent to the timeline.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it instead

@skoudoro skoudoro requested a review from m-agour July 20, 2022 20:27
@m-agour
Copy link
Contributor

m-agour commented Jul 21, 2022

Hello @xtanion,
Great job. I fount no typos but have one suggestion for improving readability: can you put a link to the PRs you are referencing in your blog post to allow the reader to have access to it?

@xtanion
Copy link
Member Author

xtanion commented Jul 21, 2022

Thanks for the review @ganimtron-10 and @m-agour

@skoudoro
Copy link
Contributor

Thanks all, merging!

@skoudoro skoudoro merged commit 5b569b3 into fury-gl:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants