Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Week 11 Blogpost #671

Merged
merged 4 commits into from Sep 6, 2022
Merged

Adding Week 11 Blogpost #671

merged 4 commits into from Sep 6, 2022

Conversation

ganimtron-10
Copy link
Contributor

Adding Weekly post

image

@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #671 (d3453a1) into master (db9771c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
- Coverage   50.40%   50.39%   -0.01%     
==========================================
  Files         120      120              
  Lines       26830    26980     +150     
  Branches     2972     2986      +14     
==========================================
+ Hits        13523    13597      +74     
- Misses      12847    12923      +76     
  Partials      460      460              
Impacted Files Coverage Δ
fury/fury/stream/tools.py 90.94% <0.00%> (-0.22%) ⬇️
fury/ui/elements.py 0.00% <0.00%> (ø)
fury/ui/tests/test_elements.py 0.00% <0.00%> (ø)
fury/fury/ui/elements.py 90.17% <0.00%> (+0.27%) ⬆️
fury/fury/ui/tests/test_elements.py 80.50% <0.00%> (+0.34%) ⬆️
fury/fury/ui/containers.py 83.37% <0.00%> (+0.44%) ⬆️

Copy link
Contributor

@m-agour m-agour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ganimtron-10 for this nice blog.
Please consider my review below.

docs/source/posts/2022/2022-08-17-week-11-praneeth.rst Outdated Show resolved Hide resolved
docs/source/posts/2022/2022-08-17-week-11-praneeth.rst Outdated Show resolved Hide resolved
docs/source/posts/2022/2022-08-17-week-11-praneeth.rst Outdated Show resolved Hide resolved
docs/source/posts/2022/2022-08-17-week-11-praneeth.rst Outdated Show resolved Hide resolved
Copy link
Member

@xtanion xtanion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @ganimtron-10, The blog LGTM. Just few commas are missing, PTAL.
Thanks

docs/source/posts/2022/2022-08-17-week-11-praneeth.rst Outdated Show resolved Hide resolved
docs/source/posts/2022/2022-08-17-week-11-praneeth.rst Outdated Show resolved Hide resolved
@ganimtron-10
Copy link
Contributor Author

Thank you for the review @m-agour and @xtanion !!

@skoudoro
Copy link
Contributor

skoudoro commented Sep 6, 2022

Thank @ganimtron-10, LGTM, merging

@skoudoro skoudoro merged commit 30d8bac into fury-gl:master Sep 6, 2022
@ganimtron-10 ganimtron-10 deleted the week-11 branch September 6, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants