New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multithreading example simplified and refactored #740
Merged
Garyfallidis
merged 28 commits into
fury-gl:master
from
Garyfallidis:multithreading_example
Feb 5, 2023
Merged
Multithreading example simplified and refactored #740
Garyfallidis
merged 28 commits into
fury-gl:master
from
Garyfallidis:multithreading_example
Feb 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Offscreen: saves at random intervals - Normal: updates the scene in a different thread than the main.
- Added is_done method to show manager which can be used to check if the context still exists. - Added a similar check to the lock_current, which allows to check if the lock was not successfully acquired.
- Added a few comments - Using three threads - Checking if the context still exists before calling fury functions inside the threads. - Fixes to format
(will be added back in another PR)
- Now exiting after counting to a 100 - Fixed typos and formatting
Spheres now use use_primitive=false - random geometry in the tests is generated with correct dimensions now - Fixed counter in the tutorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is replacing #502