Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs bar positioning in TabUI #780

Closed
guaje opened this issue Apr 11, 2023 · 12 comments
Closed

Tabs bar positioning in TabUI #780

guaje opened this issue Apr 11, 2023 · 12 comments
Labels

Comments

@guaje
Copy link
Contributor

guaje commented Apr 11, 2023

Describe the solution you'd like

The default behavior of tab-like UI components usually places them right above the content, e.g., web browser tabs. However, it would be helpful if, during the creation of a TabUI element, the user could specify where (top, bottom, left, or right) the tab bar should be placed.

tab_layout

@guaje guaje added the good first issue Good for newcomers label Apr 11, 2023
@rahulnandg
Copy link

hey, am interested in working on this one, I have proficiency in react html CSS and javascript.

@guaje
Copy link
Contributor Author

guaje commented Apr 13, 2023

hey, am interested in working on this one, I have proficiency in react html CSS and javascript.

Great @rahulnandg! Looking forward to seeing your PR.

@nikhil478
Copy link

Hello @guaje, would you kindly share the code you used to create this

@nikhil478
Copy link

nikhil478 commented Apr 18, 2023

@guaje I am currently reviewing the demo and codebase, and it seems that Panel2D was used to create it. Panel2D has a position parameter and an align parameter that currently has two options: left and right. Do you want to have four options (left, right, up, and down), or is there something else I may have missed? Could you please clarify?

edit : @guaje I discovered that the combobox2D element does not have an attribute for alignment, but it does have a position attribute that is currently optional. Can you please provide some code so that I can have a better understanding and make the necessary connections?

@nikhil478
Copy link

@guaje I am currently reviewing the demo and codebase, and it seems that Panel2D was used to create it. Panel2D has a position parameter and an align parameter that currently has two options: left and right. Do you want to have four options (left, right, up, and down), or is there something else I may have missed? Could you please clarify?

I would greatly appreciate any guidance and your feedback on this.

@IshanKamboj
Copy link
Contributor

Hello @guaje , I would like to work on this issue. My proposed solution will be to make changes in the TabUI class and adding a new parameter for tab bar positioning and then making further changes in the positioning of the tabs and content according to the tab bar position specified. I would like you to please assign me this issue.

Thank you

@IshanKamboj
Copy link
Contributor

Hello @guaje , I would like to work on this issue. My proposed solution will be to make changes in the TabUI class and adding a new parameter for tab bar positioning and then making further changes in the positioning of the tabs and content according to the tab bar position specified. I would like you to please assign me this issue.

Thank you

Also does this issue require that we should be able to place the Tabs Bar at sides like left or right? .... If so then how should it actually look like, does it need to have text in vertical direction rather than horizontal? ... Please it would be very helpful if you can clarify this.
Thank you

@guaje
Copy link
Contributor Author

guaje commented Dec 18, 2023

Hello @guaje , I would like to work on this issue. My proposed solution will be to make changes in the TabUI class and adding a new parameter for tab bar positioning and then making further changes in the positioning of the tabs and content according to the tab bar position specified. I would like you to please assign me this issue.

Thank you

Great! Looking forward to seeing your PR.

Also does this issue require that we should be able to place the Tabs Bar at sides like left or right? .... If so then how should it actually look like, does it need to have text in vertical direction rather than horizontal? ... Please it would be very helpful if you can clarify this. Thank you

I suggest you start with a top/bottom PR, and then you can create a second PR for left/right.

@IshanKamboj
Copy link
Contributor

Hello @guaje , I would like to work on this issue. My proposed solution will be to make changes in the TabUI class and adding a new parameter for tab bar positioning and then making further changes in the positioning of the tabs and content according to the tab bar position specified. I would like you to please assign me this issue.
Thank you

Great! Looking forward to seeing your PR.

Also does this issue require that we should be able to place the Tabs Bar at sides like left or right? .... If so then how should it actually look like, does it need to have text in vertical direction rather than horizontal? ... Please it would be very helpful if you can clarify this. Thank you

I suggest you start with a top/bottom PR, and then you can create a second PR for left/right.

All right, will make the first PR soon
Thank you

@Preetam-Das26
Copy link

Preetam-Das26 commented Jan 25, 2024

Is this issue resolved?
@guaje
@skoudoro

@MukulGupta005
Copy link

Hi @guaje I would like to work on this issue

@skoudoro
Copy link
Contributor

Hi @MukulGupta005,

there is already a pull request by @IshanKamboj that we need to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants