Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added blogpost week 0 #789

Merged
merged 2 commits into from Jun 7, 2023
Merged

Added blogpost week 0 #789

merged 2 commits into from Jun 7, 2023

Conversation

tvcastillod
Copy link
Contributor

Hello, here is my first blogpost.

ganimtron-10
ganimtron-10 reviewed Jun 4, 2023
View reviewed changes
Copy link
Contributor

@ganimtron-10 ganimtron-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tvcastillod,
Please take a look at the small comment below otherwise it looks great!
Also the blog generated well!
image

I am not sure whether you have tried creating the doc locally or not, but it would be great to test generating it locally and mentioning that it generated without any error so we have an idea!

docs/source/posts/2023/2023-06-02-week-0-tvcastillod.rst Outdated Show resolved Hide resolved
@tvcastillod
Copy link
Contributor Author

I am not sure whether you have tried creating the doc locally or not, but it would be great to test generating it locally and mentioning that it generated without any error so we have an idea!

@ganimtron-10 You're right, I'll keep it in mind from now on.

@skoudoro
Copy link
Contributor

skoudoro commented Jun 7, 2023

Thanks @ganimtron-10 and thanks @tvcastillod for the review.

waiting for @JoaoDell review before further action

@JoaoDell
Copy link
Contributor

JoaoDell commented Jun 7, 2023

Hey @tvcastillod you have already fixed the comment issue, so everything seems fine, good blogpost!

skoudoro
skoudoro approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tvcastillod, merging

@skoudoro skoudoro merged commit debbd21 into fury-gl:master Jun 7, 2023
2 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganimtron-10 ganimtron-10 ganimtron-10 left review comments

@skoudoro skoudoro skoudoro approved these changes

Assignees
No one assigned
Labels
type:Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tvcastillod @skoudoro @JoaoDell @ganimtron-10