Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC: Adding Week 4 Blogpost #811

Merged
merged 2 commits into from Jun 30, 2023
Merged

GSoC: Adding Week 4 Blogpost #811

merged 2 commits into from Jun 30, 2023

Conversation

ganimtron-10
Copy link
Contributor

image

Copy link
Contributor

@tvcastillod tvcastillod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @ganimtron-10, it looks like it was a fruitful week despite being busy with exams, great job. The post was generated correctly, so everything looks good to me.

Copy link
Contributor

@JoaoDell JoaoDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Praneeth, I am amidst end-semester exams as well, so seeing you accomplish so many things while going through that is impressive, good luck with all of that! About your blogpost, everything seems fine, just one change I would do below

docs/source/posts/2023/2023-06-24-week-4-praneeth.rst Outdated Show resolved Hide resolved
@ganimtron-10
Copy link
Contributor Author

Thanks for the review @tvcastillod & @JoaoDell.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #811 (b6d2020) into master (73e0a1a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #811      +/-   ##
==========================================
+ Coverage   84.41%   84.43%   +0.01%     
==========================================
  Files          43       43              
  Lines       10166    10274     +108     
  Branches     1381     1393      +12     
==========================================
+ Hits         8582     8675      +93     
- Misses       1227     1239      +12     
- Partials      357      360       +3     
Impacted Files Coverage Δ
fury/ui/containers.py 84.39% <100.00%> (+0.50%) ⬆️
fury/ui/elements.py 89.90% <100.00%> (-0.03%) ⬇️

... and 5 files with indirect coverage changes

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, Thanks to the reviewers and @ganimtron-10.

Merging

@skoudoro skoudoro merged commit 1695f61 into fury-gl:master Jun 30, 2023
21 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants