Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added blogpost week 4, 5, 6, 7 #827

Merged
merged 3 commits into from Jul 27, 2023
Merged

Conversation

tvcastillod
Copy link
Contributor

Hello, here are the blog post for weeks 4, 5, 6, and 7.

image

Copy link
Contributor

@ganimtron-10 ganimtron-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tvcastillod ,
These blogpost looks great!
I just had a small comment that we can highlight or differentiate few text mentioned below to get and idea about is it an library or a method name to get better understanding.

You can check the rst text formatting here: https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#inline-markup

docs/source/posts/2023/2023-06-27-week-4-tvcastillod.rst Outdated Show resolved Hide resolved
docs/source/posts/2023/2023-07-03-week-5-tvcastillod.rst Outdated Show resolved Hide resolved
docs/source/posts/2023/2023-07-03-week-5-tvcastillod.rst Outdated Show resolved Hide resolved
docs/source/posts/2023/2023-07-10-week-6-tvcastillod.rst Outdated Show resolved Hide resolved
docs/source/posts/2023/2023-07-17-week-7-tvcastillod.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@JoaoDell JoaoDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tvcastillod, just finished reviewing you blogposts and everything is building correctly and seems to be fine. I guess you should just check Praneeth's comments and it should be ready to be merged.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #827 (b350c93) into master (2bba1b9) will not change coverage.
Report is 9 commits behind head on master.
The diff coverage is n/a.

❗ Current head b350c93 differs from pull request most recent head af65b31. Consider uploading reports for the commit af65b31 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #827   +/-   ##
=======================================
  Coverage   84.33%   84.33%           
=======================================
  Files          44       44           
  Lines       10356    10356           
  Branches     1410     1410           
=======================================
  Hits         8734     8734           
  Misses       1252     1252           
  Partials      370      370           

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank @tvcastillod,

Can you

docs/source/posts/2023/2023-06-27-week-4-tvcastillod.rst Outdated Show resolved Hide resolved
@skoudoro
Copy link
Contributor

thank you for the update @tvcastillod , merging

@skoudoro skoudoro merged commit 06bacaa into fury-gl:master Jul 27, 2023
20 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants